Burst fire mode bug

[alerbuffon]

Hi, I need to launch Burst shooting mode,
but it doesn’t work for me (it doesn’t shoot after the first reload), everything is fine with the rest of the modes. I work with the Third Person Controller package.
Video link: https://drive.google.com/file/d/1KXMRGZx0n-SXts0_pCJ91Zz-TKByodBm/view

I'm used version of therd person controller 2.1.10
"Latest release date
Jan 26, 2020"

 

[Justin]

Thanks. It looks like this was more of a general problem with the ShootableWeapon not restarting during a reload. You can fix this by changing the top of Use.OnItemAbilityAcitve from:

            if (!IsActive || !(itemAbility is Reload)) {
                return;
            }

to:

            if (!(itemAbility is Reload)) {
                return;
            }

            // Use currently is not active, but it may have to start if the Use ability is trying to be started.
            if (!IsActive && !active && InputIndex != -1 && m_PlayerInput != null) {
                // Change the start type so the button up won't affect if the ability can start.
                var startType = m_StartType;
                if (startType == AbilityStartType.ButtonDown) {
                    m_StartType = AbilityStartType.ButtonDownContinuous;
                }
                if (CanInputStartAbility(m_PlayerInput)) {
                    StartAbility();
                }
                m_StartType = startType;
                return;
            }

Version 2.2 is in the process of being released and I'm not sure if this will be included in that. I'll edit my post if it is, otherwise it'll be in the next update.

 

[alerbuffon]

Hi Justin These changes did not help, I hope that in the next update this problem will be solved.

 

[alerbuffon]

There are also big problems with grenades. If you throw a grenade before the end of the animation, the grenade explodes in your hands, after which you can’t use grenades at all, this is also found in the demo project and inside the editor,
but if the shooting problem is not so critical for our project, then the use of grenades put us in a dead end.


I tried to record this problem on video

2020-04-22 19-08-49.mp4

drive.google.com

 

[Justin]

For the grenade are you running version 2.2? From your video it looks like the grenade is going backwards and that was fixed in 2.2.

The code above mostly fixed the burst issue, but I tried it again and there was one case that it didn't cover. You'll want to change the above to:

            if (!active && InputIndex != -1 && m_PlayerInput != null) {
                // Change the start type so the button up won't affect if the ability can start.
                var startType = m_StartType;
                if (startType == AbilityStartType.ButtonDown) {
                    m_StartType = AbilityStartType.ButtonDownContinuous;
                }
                if (CanInputStartAbility(m_PlayerInput)) {
                    if (IsActive) {
                        // The use state should be reset if the ability is currently active.
                        for (int i = 0; i < m_UsableItems.Length; ++i) {
                            if (m_UsableItems[i] == null) {
                                continue;
                            }
                            m_UsableItems[i].StartItemUse(this);
                            ResetCanStopEvent(i);
                        }
                        InputIndex = -1;
                    } else {
                        // The ability isn't active, but it should be.
                        StartAbility();
                    }
                }
                m_StartType = startType;
                return;
            }

I also added the following to ShoootableWeapon.StartItemUse:

            BurstReset();