[Bug] ThrowableItem only hides FirstPersonObject/ThirdPersonObject MeshRenderers but not other Renderes like SkinnedMeshRenderer

[echtnice]

Hi,

I try to use the ThrowableItem on the Pistol from the ThirdPersonDemo scene. The pistol uses MeshRenderer but also multiple SkinnedMeshRenderer. We also added another LineRenderer to the demo Pistol to show a Laser.
The problem is, that the ThrowableItem only hides the MeshRenderer but leaves any other Renderer visible when throwing.
We changed the code to hide all Renderer components instead of only MeshRenderer and it survived a simple test and now hides the Pistol.

Is that a problem with the ThrowableItem or did we use it wrong?

Hers is our local patch:

Index: Assets/Opsive/UltimateCharacterController/Scripts/Items/Actions/ThrowableItem.cs
IDEA additional info:
Subsystem: com.intellij.openapi.diff.impl.patch.CharsetEP
<+>UTF-8
===================================================================
--- Assets/Opsive/UltimateCharacterController/Scripts/Items/Actions/ThrowableItem.cs    (revision 94ac17feaba5ab6c4d911eba5b38e19830f71ade)
+++ Assets/Opsive/UltimateCharacterController/Scripts/Items/Actions/ThrowableItem.cs    (date 1587053910853)
@@ -124,8 +124,8 @@
 
         private GameObject m_Object;
         private Transform m_ObjectTransform;
-        private MeshRenderer[] m_FirstPersonObjectMeshRenderers;
-        private MeshRenderer[] m_ThirdPersonObjectMeshRenderers;
+        private Renderer[] m_FirstPersonObjectMeshRenderers;
+        private Renderer[] m_ThirdPersonObjectMeshRenderers;
         private IThrowableItemPerspectiveProperties m_ThrowableItemPerpectiveProperties;
         private GameObject m_InstantiatedThrownObject;
         protected TrajectoryObject m_InstantiatedTrajectoryObject;
@@ -215,14 +215,14 @@
             if (firstPersonPerspectiveItem != null) {
                 var visibleObject = firstPersonPerspectiveItem.GetVisibleObject();
                 if (visibleObject != null) {
-                    m_FirstPersonObjectMeshRenderers = visibleObject.GetComponentsInChildren<MeshRenderer>(true);
+                    m_FirstPersonObjectMeshRenderers = visibleObject.GetComponentsInChildren<Renderer>(true);
                 }
             }
             var thirdPersonPerspectiveItem = m_Item.ThirdPersonPerspectiveItem;
             if (thirdPersonPerspectiveItem != null) {
                 var visibleObject = thirdPersonPerspectiveItem.GetVisibleObject();
                 if (visibleObject != null) {
-                    m_ThirdPersonObjectMeshRenderers = visibleObject.GetComponentsInChildren<MeshRenderer>(true);
+                    m_ThirdPersonObjectMeshRenderers = visibleObject.GetComponentsInChildren<Renderer>(true);
                 }
             }
             if (m_ThrowableItemPerpectiveProperties == null) {

 

[Justin]

Changing to a Renderer instead of a MeshRendere makes sense - thanks!