[BUG] Issue inside Ability.cs root motion override attributes?

[visiblenoise]

Character controller variant (Ultimate Character Controller, First Person Controller, etc):
Third Person Controller v2.4.8

This is just something I happened to notice from looking at the code, so the other info isn't relevant.

In Ability.cs, where it is checking for root motion position/rotation overrides, at line 527 it checks m_UseRootMotionRotation, but the accompanying else-if in 529 checks m_UseRootMotionPosition. Then if it enters it sets AllowRootMotionRotation. Shouldn't line 529 be checking m_UseRootMotionRotation instead?

 

[Justin]

The current code is correct. This will allow the locomotion component to have its own settings.

 

[visiblenoise]

I understand the general design of allowing the locomotion component to have its own settings, I just didn't understand why a position setting should affect rotation behavior.

In any case, thanks for confirming.